Skip to content

[Mono.Android] remove Xamarin.Android.VSAndroidDesigner.IsSupported feature switch#9471

Merged
jonpryor merged 1 commit into
mainfrom
Xamarin.Android.VSAndroidDesigner.IsSupported
Nov 8, 2024
Merged

[Mono.Android] remove Xamarin.Android.VSAndroidDesigner.IsSupported feature switch#9471
jonpryor merged 1 commit into
mainfrom
Xamarin.Android.VSAndroidDesigner.IsSupported

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132
Context: 363935b

As the Android designer is no longer supported in Visual Studio, we are removing the Xamarin.Android.VSAndroidDesigner.IsSupported feature switch and $(VSAndroidDesigner) MSBuild property.

This removes the codepath for Java types at runtime (on desktop) via TypeManager.TypeRegistrationFallback(). This also removes a Console.WriteLine() call when liblog and __android_log_print cannot be found.

… feature switch

Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132
Context: 363935b

As the Android designer is no longer supported in Visual Studio, we
are removing the `Xamarin.Android.VSAndroidDesigner.IsSupported`
feature switch and `$(VSAndroidDesigner)` MSBuild property.

This removes the codepath for Java types at runtime (on desktop) via
`TypeManager.TypeRegistrationFallback()`. This also removes a
`Console.WriteLine()` call when `liblog` and `__android_log_print`
cannot be found.
@jonathanpeppers jonathanpeppers marked this pull request as ready for review October 30, 2024 20:52

@dellis1972 dellis1972 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@jonpryor jonpryor merged commit 6ac69be into main Nov 8, 2024
@jonpryor jonpryor deleted the Xamarin.Android.VSAndroidDesigner.IsSupported branch November 8, 2024 19:52
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants