Skip to content

Trim FSharp.Core package dependencies#1225

Merged
KevinRansom merged 1 commit into
dotnet:masterfrom
cartermp:fscore-trim
May 30, 2016
Merged

Trim FSharp.Core package dependencies#1225
KevinRansom merged 1 commit into
dotnet:masterfrom
cartermp:fscore-trim

Conversation

@cartermp

@cartermp cartermp commented May 27, 2016

Copy link
Copy Markdown
Contributor
  • Fixes a redundant reference to Microsoft.NETCore.Platforms
  • Removes 14 unused packages from NETStandard.Library
  • Removes unused reference to System.Reflection.TypeExtensions

Rationale:

NETStandard.Library contains a lot of packages which aren't always used. Trimming those unused dependencies is considered a best practice for package authors. This PR does that.

@msftclas

Copy link
Copy Markdown

Hi @cartermp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Phillip Carter). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@forki

forki commented May 28, 2016

Copy link
Copy Markdown
Contributor

Awesome.

@dsyme

dsyme commented May 28, 2016

Copy link
Copy Markdown
Contributor

That's very nice

@KevinRansom KevinRansom merged commit 02b490d into dotnet:master May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants