Skip to content

Tests: clean-up unneeded code#17762

Closed
majocha wants to merge 4 commits into
dotnet:mainfrom
majocha:single-test
Closed

Tests: clean-up unneeded code#17762
majocha wants to merge 4 commits into
dotnet:mainfrom
majocha:single-test

Conversation

@majocha

@majocha majocha commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Since the tests run in temp directories by default, this code in single-test.fs should no longer be needed.

Let's see if it is.

@majocha majocha requested a review from a team as a code owner September 18, 2024 05:40
@github-actions

Copy link
Copy Markdown
Contributor

✅ No release notes required

@KevinRansom

Copy link
Copy Markdown
Contributor

Yeah!!! the tests are probably not as consistent as you think. Different tests, even within the ComponentTests suite have different strategies ... usually depending on how the test originally work.

@majocha

majocha commented Sep 18, 2024

Copy link
Copy Markdown
Contributor Author

I think I had that special case handled for that helloworld thing. I'll look into it, as this change works in my experiment PR.

@majocha

majocha commented Sep 18, 2024

Copy link
Copy Markdown
Contributor Author

Yes it's like geological strata, sediments upon sediments. But it seems this worked :)

@psfinaki

Copy link
Copy Markdown
Contributor

Yeah. We are doing geological programming this week :)

Consider conducting some smoke testing from whatever applies in this comment to a sibling PR - among other things, doing this will just help us "compile" some sanity checks for these sorts of PRs.

@majocha

majocha commented Sep 28, 2024

Copy link
Copy Markdown
Contributor Author

Subsumed by #17815

@majocha majocha closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants