Remove unused useSyntaxTreeCache option#17768
Merged
Merged
Conversation
Contributor
❗ Release notes required
|
Contributor
|
I think surface area will need an update as well. |
majocha
force-pushed
the
remove-option
branch
from
13b3072 to
71cfac2
Compare
Contributor
Author
|
The consensus is to remove it. It was also still marked experimental. |
Contributor
|
I just noticed it's also present in VS settings. I think we should remove it there as well then :) |
Contributor
|
(use_syntax_tree_cache) |
Contributor
Author
|
I think this is already done in this PR. |
Contributor
|
Right, sorry, I somehow mis-scrolled it 🤦 Thanks! |
psfinaki
approved these changes
Sep 26, 2024
psfinaki
left a comment
psfinaki
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I think this PR can serve as a good manual on how to add / remove an option to the compiler and propagate / unpropagate it everywhere :)
Contributor
|
Oh I know what I meant. This is still left in the resources via keywords, here. So can be removed there as well. |
Contributor
Author
|
Right, couldn't find anything with search in files, makes sense now :) |
T-Gro
approved these changes
Sep 30, 2024
This was referenced Oct 31, 2024
This was referenced Sep 8, 2025
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up.
This functionality is no longer configurable, and that cache no longer exists as a separate value in the builder.
Instead
SyntaxTreecaching occurs naturally by preservingGraphNodecomputed values, IIRC.