Skip to content

show type of ignored expression#4197

Merged
KevinRansom merged 4 commits into
dotnet:masterfrom
dsyme:fix-4163
Jan 24, 2018
Merged

show type of ignored expression#4197
KevinRansom merged 4 commits into
dotnet:masterfrom
dsyme:fix-4163

Conversation

@dsyme

@dsyme dsyme commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

WIP to address #4163

In all cases

The result of this expression is implicitly ignored. ...

becomes

The result of this expression has type '{0}' and is implicitly ignored.

@dsyme

dsyme commented Jan 17, 2018

Copy link
Copy Markdown
Contributor Author

This is ready once green

@forki

forki commented Jan 20, 2018

Copy link
Copy Markdown
Contributor

@dsyme this is part of what we talked about yesterday. We should even be more explicit if the expression is in a list comprehension. In that case it's almost never correct (but just indentation issue) and the warning is not helpful.

@KevinRansom KevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Don

Kevin

@KevinRansom KevinRansom merged commit 203d70e into dotnet:master Jan 24, 2018
T-Gro pushed a commit that referenced this pull request Jun 12, 2026
* show type of ignored expression

* fix tests

* fix tests

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants