Test revert of #4173 #4347
Merged
Merged
Conversation
This reverts commit f9893b6.
Contributor
Author
Contributor
Author
|
@brettfo Is it OK if we apply this to the master branch too? I just want the core compiler logic to be in sync, so we can integrate it to Mono etc. (Mono release repo https://github.com/fsharp/fsharp is formed by integrating "master" branch here) |
Member
|
Yes we plan on merging |
Contributor
Author
|
@brettfo Thanks. Merging since it was green before I opened it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that we should revert #4173 until we understand the issues better and to ensure stability between F# 4.1 and its update releases.
See customer-reported issue #4343
This is trialling a revert of combined commit f9893b6.