Skip to content

CherryPick into dev15.8 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557))#5597

Merged
brettfo merged 1 commit into
dotnet:dev15.8from
KevinRansom:cp5504
Sep 11, 2018
Merged

CherryPick into dev15.8 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557))#5597
brettfo merged 1 commit into
dotnet:dev15.8from
KevinRansom:cp5504

Conversation

@KevinRansom

@KevinRansom KevinRansom commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

The issue is that when we do a build in the ide we copy all of the msbuild global loggers into the project. This behavior is incorrect and causes them to be used multiple times during a build. Those global loggers are not required or in some cases not designed to be reusable in that way. Causing the internal error.

The resolution is to not use the Global Loggers in our design time build.

@KevinRansom KevinRansom changed the title CherryPick into dev15.9 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557)) CherryPick into dev15.8 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557)) Sep 6, 2018
@KevinRansom

Copy link
Copy Markdown
Contributor Author

@dotnet-bot test Ubuntu16.04 Release_default Build please

2 similar comments
@KevinRansom

Copy link
Copy Markdown
Contributor Author

@dotnet-bot test Ubuntu16.04 Release_default Build please

@KevinRansom

Copy link
Copy Markdown
Contributor Author

@dotnet-bot test Ubuntu16.04 Release_default Build please

@brettfo brettfo merged commit 55a3dc3 into dotnet:dev15.8 Sep 11, 2018
@KevinRansom KevinRansom deleted the cp5504 branch September 15, 2018 18:09
T-Gro pushed a commit that referenced this pull request Jun 12, 2026
CherryPick into dev15.8 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants