Skip to content

Remove project cracker#8288

Merged
cartermp merged 3 commits into
dotnet:masterfrom
Krzysztof-Cieslak:remove-project-cracker
Jan 20, 2020
Merged

Remove project cracker#8288
cartermp merged 3 commits into
dotnet:masterfrom
Krzysztof-Cieslak:remove-project-cracker

Conversation

@Krzysztof-Cieslak

Copy link
Copy Markdown
Contributor

PR removes obsoleted ProjectCracker tool from the FSharp.Compiler.Service. This was discussed in fsharp/fsharp-compiler-docs#905

@dnfclas

dnfclas commented Jan 20, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@TIHan TIHan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I feel like @cartermp or @KevinRansom might have more context on this specifically, so I would like either of them to just make sure this is good too.

@cartermp cartermp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yee

@cartermp cartermp merged commit e20fc26 into dotnet:master Jan 20, 2020
@Krzysztof-Cieslak Krzysztof-Cieslak deleted the remove-project-cracker branch January 20, 2020 14:58
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Remove ProjectCracker project

* Remove Project Cracker tests

* Remove ProjectCracker docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants