[GEF] Remove state duplication in Tool class#1559
Open
ptziegler wants to merge 1 commit into
Open
Conversation
Test Results 4 files ±0 4 suites ±0 2h 21m 21s ⏱️ + 3m 34s For more details on these failures and errors, see this check. Results for commit 8c35c80. ± Comparison against base commit b8750d6. ♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
gef-tool-state
branch
5 times, most recently
from
aa12ab3 to
8c35c80
Compare
The same functionality provided by our ´Tool´ class can be gained by extending the `AbstractTool` class directly.
ptziegler
force-pushed
the
gef-tool-state
branch
from
8c35c80 to
7fd16d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
m_statefield of ourToolclass and redirects access to theisInState(...)andsetState(...)methods, which interact with the private field of theAbstractToolclass.