Document laravel prepared set and add coverage - #77
Merged
Conversation
Add README example for withPreparedSets(laravel: true) and a set test covering the Laravel Pint ruleset. Claude-Session: https://claude.ai/code/session_01Gmzc2bKAUjQHrSKVQsPruQ
The laravel set is the first prepared set to use withSkip(). Its skip entries leaked across tests because SimpleParameterProvider is static and never reset, breaking Psr12 and SkippedPathsResolver tests. Reset the static parameters at the start of each container build. Claude-Session: https://claude.ai/code/session_01Gmzc2bKAUjQHrSKVQsPruQ
Update renamed fixers (braces_position, modifier_keywords, spaces_inside_parentheses, type_declaration_spaces, native_type_declaration_casing, compact_nullable_type_declaration, no_unneeded_braces, blank_lines_before_namespace), add missing rules (yoda_style, ordered_interfaces/traits, phpunit casing and visibility, nullable type declarations, single line comment style, phpdoc_align, fully_qualified_strict_types config, ordered_imports grouping, and more), enable statement_indentation, and drop project-level path excludes that are not part of the preset. Claude-Session: https://claude.ai/code/session_01Gmzc2bKAUjQHrSKVQsPruQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Laravel Pint preset (
config/set/laravel.php,SetList::LARAVEL,withPreparedSets(laravel: true)) already exists in the codebase but was undocumented and untested.->withPreparedSets(laravel: true)with a link to the source Pint presetLaravelTestset test with a fixture, mirroring the PER-CS and PSR-12 set testscomposer lintand the new test pass.https://claude.ai/code/session_01Gmzc2bKAUjQHrSKVQsPruQ