fix: DIPs pipeline monitor undercounts accepted indexers#82
Merged
MoonBoi9001 merged 1 commit intoJun 22, 2026
Merged
Conversation
The pipeline monitor's summary counted unique status values, so three indexers all accepting on-chain were reported as "1 accepted". Count the agreements directly so the summary matches the per-indexer lines printed above it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The script that watches a DIPs indexing request reports how many indexers accepted, but it counted distinct status values instead of agreements — so any number of indexers accepting on-chain showed as "1 accepted". This counts the agreements directly.
Motivation
When you register a DIPs indexing request, a monitoring script tails the pipeline and prints a final summary line like
done: N accepted, M failed. That summary collapsed every agreement down to its set of unique status values before counting, so three indexers all reaching on-chain acceptance were reported as a single accepted agreement. The per-indexer lines printed just above already show the real outcome, which made the summary look broken and undercounted every successful run — misleading anyone reading the test output or scripting against the counts.Summary
Generated with Claude Code