Skip to content

fix: DIPs pipeline monitor undercounts accepted indexers#82

Merged
MoonBoi9001 merged 1 commit into
samuel/dips-dev-environmentfrom
mb9/fix-dips-monitor-accepted-counter
Jun 22, 2026
Merged

fix: DIPs pipeline monitor undercounts accepted indexers#82
MoonBoi9001 merged 1 commit into
samuel/dips-dev-environmentfrom
mb9/fix-dips-monitor-accepted-counter

Conversation

@MoonBoi9001

Copy link
Copy Markdown
Member

TL;DR

The script that watches a DIPs indexing request reports how many indexers accepted, but it counted distinct status values instead of agreements — so any number of indexers accepting on-chain showed as "1 accepted". This counts the agreements directly.

Motivation

When you register a DIPs indexing request, a monitoring script tails the pipeline and prints a final summary line like done: N accepted, M failed. That summary collapsed every agreement down to its set of unique status values before counting, so three indexers all reaching on-chain acceptance were reported as a single accepted agreement. The per-indexer lines printed just above already show the real outcome, which made the summary look broken and undercounted every successful run — misleading anyone reading the test output or scripting against the counts.

Summary

  • Count accepted and failed agreements over the agreement list, not the deduplicated status set.
  • The all-agreements-terminal check still uses the status set; only the summary counts change.

Generated with Claude Code

The pipeline monitor's summary counted unique status values, so three indexers all accepting
on-chain were reported as "1 accepted". Count the agreements directly so the summary matches
the per-indexer lines printed above it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@MoonBoi9001 MoonBoi9001 merged commit 6ac3ce8 into samuel/dips-dev-environment Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant