fix(webflux): fix NoSuchMethodError when using spring framework 7 wit…#4514
Closed
jihadbou15 wants to merge 1 commit into
Closed
fix(webflux): fix NoSuchMethodError when using spring framework 7 wit…#4514jihadbou15 wants to merge 1 commit into
jihadbou15 wants to merge 1 commit into
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
🤖 GitHub commentsJust comment with:
|
33f996d to
440014c
Compare
Author
|
Will remake the PR as i committed with the wrong account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h webflux
What does this PR do?
This PR fixes an issue with the experimental support for Spring framework 7 that was added PR. When running the agent, it will throw a NoSuchMethodError exception due to the
HttpHeaders.entrySetmethod. This is due to HttpHeaders no longer implementing the MultiValueMap contract.I have changed the copying of header to only use API's that are still available across version 5, 6 and 7.
The test
co.elastic.apm.agent.springwebflux.AbstractServerInstrumentationTest#dispatchHellocovers this fix.Checklist