Conversation
saschanaz
added a commit
to saschanaz/jxl-wasm
that referenced
this pull request
Dec 30, 2020
This depends on emscripten-core/emscripten#13139. Closes #2
kripken
reviewed
Jan 7, 2021
kripken
left a comment
Member
There was a problem hiding this comment.
What is the relationship between JPEG XL and libgif? (Sorry, I don't know much about this area - when I did a search for libgif I found "giflib" which doesn't mention JPEG XL at all, is that something else?)
Collaborator
Author
|
giflib is libgif as zlib is libz. Maybe it should be giflib here to follow zlib. |
Collaborator
Author
https://gitlab.com/wg1/jpeg-xl depends on giflib to decode gif. I just intended to say I tested this with a real world project. |
d3f17cd to
c11f202
Compare
Member
|
I see, thanks @saschanaz ! Ok, looks good, just please add a test before we land. Can be similar to the test for libjpeg for example, emscripten/tests/test_other.py Lines 1501 to 1506 in 63422ac |
kripken
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can successfully build JPEG XL reference software with GIF support.