Run asan and lsan suites without -O2#15176
Conversation
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
This will compile more quickly, but it may run a lot more slowly as ASan checks can be optimized out, so I actually worry this may be quite slow. That might be worth checking.
Looks like we added -O2 over here, for SIMD reasons #12249 (comment) @tlively may remember more, but if tests pass maybe that problem has gone away.
|
According to https://github.com/emscripten-core/emscripten/pull/12249/files#r492308304 this was because the "too many locals" issue.. which I dealt with more precisely in this PR. The fact that we only added |
Running them in `-O2` means llvm does optimizations which can hide memory leaks (e.g. In some cases it can completely elinate calls allocations due to malloc/new when the resulting pointer don't escape). This should also speed up running these test suites. Also, fix test_em_asm_2 under asan.
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Makes sense.
I'd still suggest looking at compile times, but as this wasn't an issue before, likely it's fine.
Do you mean execution times? I'm not to worried about that.. asan execution times are excepted to be slow anyway. I will measure but unless its something like 10x slower I suggest we keep this setting since it also makes the stack traces on failure more readable. Perhaps once we have lsan up and running in CI we can using |
3 participants
Running them in
-O2means llvm does optimizations which can hidememory leaks (e.g. In some cases it can completely elinate calls
allocations due to malloc/new when the resulting pointer don't escape).
This should also speed up running these test suites.
Also, fix test_em_asm_2 under asan.
This change contains some parts that were split out from #15099.