Restore xlocale.h compat header.#17111
Merged
Merged
Conversation
walkingeyerobot
approved these changes
May 31, 2022
walkingeyerobot
left a comment
walkingeyerobot
left a comment
Collaborator
There was a problem hiding this comment.
thanks very much!
kripken
reviewed
May 31, 2022
kripken
approved these changes
May 31, 2022
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
lgtm assuming the test+output files are the same ones as from before
This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in libcxx build") Alos, add a new test for this header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in
libcxx build")
Alos, add a new test for this header.