Update JS library signatures#18995
Merged
Merged
Conversation
sbc100
force-pushed
the
update_sigs
branch
2 times, most recently
from
6395584 to
b3746ad
Compare
dschuff
reviewed
Mar 18, 2023
sbc100
added a commit
that referenced
this pull request
Mar 19, 2023
Split out from #18995 since I noticed that it wasn't just the `__sig` by actually the argument list that was wrong in this case.
kripken
approved these changes
Mar 20, 2023
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
Split out from #18995 since I noticed that it wasn't just the `__sig` by actually the argument list that was wrong in this case.
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
Split out from #18995 since I noticed that it wasn't just the `__sig` by actually the argument list that was wrong in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was almost entirely automatically generated by the tool I'm working on as part of #18979. Once this change lands, I plan to completely remove these signatures and instead auto-generate them, but in order to make that change into no-op I'd like to first update them all in-place.
The one exception, where I hand edited, are the
emscripten_audio_workletwhere I removed the usage of aliases so that each function could have its own signature.See #18985