Drop types-certifi package. - #472
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We really don't care about mypy verifying for us that
certifi.where()returns astr.It's not worth the package download of
types-certifion every CI run.Somewhat minded to use
mypy --ignore-missing-imports, which would also allow us to drop that type-stub package. We usemypyand type checking throughout our package in order to ensure internal consistency. It's a form of test suite, and allows us to much more safely undertake changes and refactoring when needed. I don't care half as much about what type signatures packages we rely on advertise.Here's what the
types-certifipackage installs for us: https://github.com/python/typeshed/blob/master/stubs/certifi/certifi.pyiRelated reading: https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports