Skip to content

chore: fix race condition in auth tenant management tests #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanedey wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: fix race condition in auth tenant management tests #3218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dadf83
chore: fix race condition in auth tenant management tests
jonathanedey Jul 23, 2026
a723183
chore: apply gemini review
jonathanedey Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 18 additions & 22 deletions test/integration/auth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,30 +2398,26 @@ describe('admin.auth', () => {
});
});

it('deleteTenant() should successfully delete the provided tenant', () => {
const allTenantIds: string[] = [];
const listAllTenantIds = (tenantIds: string[], nextPageToken?: string): Promise<void> => {
return getAuth().tenantManager().listTenants(100, nextPageToken)
.then((result) => {
result.tenants.forEach((tenant) => {
tenantIds.push(tenant.tenantId);
});
if (result.pageToken) {
return listAllTenantIds(tenantIds, result.pageToken);
}
describe('tenant deletion operations', () => {
it('deleteTenant() should successfully delete the provided tenant', async () => {
const allTenantIds: string[] = [];
const listAllTenantIds = async (tenantIds: string[], nextPageToken?: string): Promise<void> => {
const result = await getAuth().tenantManager().listTenants(100, nextPageToken);
result.tenants.forEach((tenant) => {
tenantIds.push(tenant.tenantId);
});
};
if (result.pageToken) {
await listAllTenantIds(tenantIds, result.pageToken);
}
};

return getAuth().tenantManager().deleteTenant(createdTenantId)
.then(() => {
// Use listTenants() instead of getTenant() to check that the tenant
// is no longer present, because Auth Emulator implicitly creates the
// tenant in getTenant() when it is not found
return listAllTenantIds(allTenantIds);
})
.then(() => {
expect(allTenantIds).to.not.contain(createdTenantId);
});
await getAuth().tenantManager().deleteTenant(createdTenantId);
// Use listTenants() instead of getTenant() to check that the tenant
// is no longer present, because Auth Emulator implicitly creates the
// tenant in getTenant() when it is not found
await listAllTenantIds(allTenantIds);
expect(allTenantIds).to.not.contain(createdTenantId);
});
});
});

Expand Down
Loading