Skip to content

Add PHP to the default documentation set (#2706) #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vam-si-krish wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Add PHP to the default documentation set (#2706) #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class App < Sinatra::Application
set :docs_origin, File.join('', docs_prefix)
set :docs_path, File.join(public_folder, docs_prefix)
set :docs_manifest_path, File.join(docs_path, 'docs.json')
set :default_docs, %w(css dom html http javascript)
set :default_docs, %w(css dom html http javascript php)
set :news_path, File.join(root, assets_prefix, 'javascripts', 'news.json')

set :csp, false
Expand Down
2 changes: 1 addition & 1 deletion lib/docs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def self.all_versions
end

def self.defaults
%w(css dom html http javascript).map(&method(:find))
%w(css dom html http javascript php).map(&method(:find))
end

def self.installed
Expand Down
5 changes: 5 additions & 0 deletions test/app_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ def app
current_session.env('HTTPS', 'on')
end

it 'includes PHP in the default documentation set' do
assert_includes App.settings.default_docs, 'php'
assert_includes Docs.defaults.map(&:name), 'PHP'
end

it 'redirects to HTTPS' do
get 'http://example.com/test?q=1', {}, 'HTTPS' => 'off'
assert last_response.redirect?
Expand Down