test(compositor): measure the Linux cursor trail over a one-frame shutter - #684
EtienneLescot wants to merge 1 commit into
Conversation
…tter plan_cursor bounds the cursor motion-blur shutter to one frame (trail_dt = blur01 / FPS) since 34b2e58, but compose_linux_trainee_de_curseur still assumed an 8/60 s trail (~256 px at 960 wide). The trail is now ~32 px at that speed, hidden under the 51 px sprite, so the measurement window was empty and the opt-in test failed on main. Move the cursor four times faster so one frame spans ~128 px, and measure between the oldest copy and the current sprite (x 670..738). Comments now describe the one-frame shutter.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Linux compositor cursor-trail test now models a one-frame shutter. It uses a faster cursor track, an earlier sample time, shifted measurement windows, and a lower green-pixel threshold. ChangesCursor trail test retuning
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The cursor-trail test changes are internally consistent with the one-frame shutter and do not present a merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the test failure, the updated measurement values, and verification results. However, it does not follow the required template and omits the Summary, Related issue, Type of change, Release impact, Desktop impact, and Screenshots / video sections. Resolution Add the missing template sections. Complete the applicable checkboxes for change type, release impact, and Linux desktop impact. State whether there is a related issue, indicate when screenshots or video are not applicable, and retain the existing testing details under the Testing section.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Clippy (1.98.0)Clippy execution failed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Intégrée dans |
`compose_linux_trainee_de_curseur` fails on main since 34b2e58 bounded the cursor shutter to one frame (`trail_dt = blur01 / FPS`). The test still assumed an 8/60 s trail, so its measurement window was empty.
Change
Verified under WSL with lavapipe (local `Gpu::create_auto` patch, `OPENSCREEN_LINUX_COMPOSE=1`)
Not in scope: on lavapipe, `annotation_flou_et_mosaique`, `flou_de_velocite_ecran` and `sans_camera_ne_dessine_pas_de_vignette` fail too, identically before and after this change.
🤖 Generated with Claude Code
Summary by CodeRabbit