Skip to content

revert: back out the 3D effects until they run on macOS and Linux - #703

Merged
EtienneLescot merged 1 commit into
mainfrom
revert/3d-effects-untested
Sep 17, 2026
Merged

revert: back out the 3D effects until they run on macOS and Linux#703
EtienneLescot merged 1 commit into
mainfrom
revert/3d-effects-untested

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Sep 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

#682 was merged by mistake before the 3D workstream was run on macOS or on a real Linux GPU. Its CI was green, but on Linux only the software renderer had run, and on macOS only the CI tests.

What this reverts: the 9 3D commits of #682 (2c2b14f4..d8190181): tilt parallax, click impact, cursor volume, programme time, animated backgrounds, window frame, depth of field, follow-cursor camera and modelled cursor, German strings.

What stays: the two unrelated fixes from the same series:

  • 2a7ffb3f: Linux cursor-trail test.
  • 53004e0b: dev HTTP cache switch.

Next step: re-land the workstream (revert this revert) once the app has been run on macOS and Linux.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Removed Features
    • Removed animated gradient backgrounds, window-frame decorations, depth-of-field effects, click-impact effects, and 3D modeled cursors.
    • Removed follow-cursor camera movement and projective camera warping.
    • Removed programme-time controls and pinned click-point behavior.
  • Updated Experience
    • 3D zoom now uses fixed rotation presets: Isometric, Left, and Right.
    • Cursor and screen rendering use simplified, consistent positioning across platforms.
    • Preview annotations now align with the standard layout bounds.
  • Documentation
    • Updated settings labels, project storage, migrations, and documentation to reflect the streamlined options.

@EtienneLescot
revert: back out the 3D effects until they run on macOS and Linux
4933903 
Reverts 2c2b14f..d819018 (#682), merged before anyone ran the app on macOS
or on a real Linux GPU. The two unrelated fixes of that series stay: the Linux
cursor-trail test (2a7ffb3) and the dev HTTP cache switch (53004e0).
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 17b42adf-c47f-457b-94fe-5edec45a1afc

📥 Commits

Reviewing files that changed from the base of the PR and between d819018 and 4933903.

⛔ Files ignored due to path filters (1)
  • crates/compositor/src/shaders.hlsl is excluded by !**/*.hlsl
📒 Files selected for processing (81)
  • crates/compositor/src/camera.rs
  • crates/compositor/src/compositor_linux.rs
  • crates/compositor/src/compositor_macos.rs
  • crates/compositor/src/compositor_windows.rs
  • crates/compositor/src/cursor.rs
  • crates/compositor/src/cursor_sdf.rs
  • crates/compositor/src/frame_geometry.rs
  • crates/compositor/src/lib.rs
  • crates/compositor/src/live.rs
  • crates/compositor/src/regions.rs
  • crates/compositor/src/scene.rs
  • crates/compositor/src/shaders.metal
  • crates/compositor/src/timeline_walk.rs
  • crates/compositor/src/vk_shaders/layer.wgsl
  • crates/compositor/tests/animated_background.rs
  • crates/compositor/tests/click_impact_render.rs
  • crates/compositor/tests/compose_linux.rs
  • crates/compositor/tests/cursor_model_render.rs
  • crates/compositor/tests/cursor_tap_render.rs
  • crates/compositor/tests/follow_camera_render.rs
  • crates/compositor/tests/programme_time_seek.rs
  • crates/compositor/tests/tilt_parallax_render.rs
  • crates/compositor/tests/tilted_depth_of_field.rs
  • crates/compositor/tests/tilted_depth_slot_inert.rs
  • crates/compositor/tests/window_frame_render.rs
  • crates/fixture/scene-gradient-aurora.json
  • crates/fixture/scene-gradient-still.json
  • crates/fixture/scene-tilt.json
  • crates/poc-d3d/src/bench.rs
  • docs/3d-effects-v2.md
  • electron/ai-edition/style-preset-service.test.ts
  • electron/ipc/nativeBridge.presets.test.ts
  • src/components/ai-edition/PreviewCanvas.tsx
  • src/components/ai-edition/RightPanes.backgroundMotion.test.tsx
  • src/components/ai-edition/RightPanes.i18n.test.tsx
  • src/components/ai-edition/RightPanes.tsx
  • src/components/ai-edition/depthOfFieldToggle.test.tsx
  • src/components/ai-edition/fitClipShapes.test.tsx
  • src/components/ai-edition/v4/FloatingInspector.test.tsx
  • src/components/ai-edition/v4/FloatingInspector.tsx
  • src/components/video-editor/editorDefaults.ts
  • src/components/video-editor/projectPersistence.test.ts
  • src/components/video-editor/projectPersistence.ts
  • src/components/video-editor/types.ts
  • src/i18n/locales/ar/settings.json
  • src/i18n/locales/cs/settings.json
  • src/i18n/locales/de/settings.json
  • src/i18n/locales/en/settings.json
  • src/i18n/locales/es/settings.json
  • src/i18n/locales/fr/settings.json
  • src/i18n/locales/it/settings.json
  • src/i18n/locales/ja-JP/settings.json
  • src/i18n/locales/ko-KR/settings.json
  • src/i18n/locales/pt-BR/settings.json
  • src/i18n/locales/ru/settings.json
  • src/i18n/locales/tr/settings.json
  • src/i18n/locales/vi/settings.json
  • src/i18n/locales/zh-CN/settings.json
  • src/i18n/locales/zh-TW/settings.json
  • src/lib/ai-edition/document/migrate.test.ts
  • src/lib/ai-edition/document/migrate.ts
  • src/lib/ai-edition/schema/index.ts
  • src/lib/ai-edition/store/documentWriteAudit.test.ts
  • src/lib/ai-edition/store/editorSettings.test.ts
  • src/lib/ai-edition/store/editorSettings.ts
  • src/lib/ai-edition/store/useTimeline.test.ts
  • src/lib/ai-edition/store/useTimeline.ts
  • src/lib/ai-edition/stylePresets.test.ts
  • src/lib/ai-edition/stylePresets.ts
  • src/lib/ai-edition/stylePresetsEditor.test.ts
  • src/lib/ai-edition/stylePresetsEditor.ts
  • src/lib/compositeLayout.test.ts
  • src/lib/compositeLayout.ts
  • src/lib/projectDefaults.ts
  • src/native/browserShim.presets.test.ts
  • src/native/nativeCompositorStore.test.ts
  • src/native/nativeCompositorStore.ts
  • src/native/sceneDescription.test.ts
  • src/native/sceneDescription.ts
  • technical-documentation/engineering/rendering-performance.md
  • technical-documentation/testing/manual-e2e-checklist.md
📝 Walkthrough

Walkthrough

The change removes the follow-cursor camera and several related compositor features. It simplifies rotation projection to fixed presets and bilinear mapping. Editor contracts, persistence, native serialization, UI controls, localization, fixtures, tests, and documentation now omit the removed features.

Changes

Compositor rendering and contracts

Layer / File(s) Summary
Compositor contracts and rotation model
crates/compositor/src/{camera.rs,regions.rs,scene.rs,cursor.rs,live.rs}, crates/compositor/src/compositor_*		 The orbital camera, programme clock, modeled cursor state, click-impact state, animated gradients, depth-of-field state, and window-frame state are removed. Fixed rotation presets and bilinear TiltedQuad mapping remain.
Shader paths and compositor validation
crates/compositor/src/shaders.metal, crates/compositor/src/vk_shaders/layer.wgsl, crates/compositor/tests/*		 Shader modes for removed features and their integration tests are deleted. Remaining tilted-screen, mask, cursor, and gradient paths use static or bilinear behavior.
Editor contracts, persistence, and migration
src/components/video-editor/*, src/lib/ai-edition/*, src/native/*, src/lib/projectDefaults.ts		 Types, schemas, project persistence, style presets, migrations, native scene serialization, and native parameter forwarding no longer carry the removed settings. Rotation values are limited to none, iso, left, and right.
Editor UI and localized settings
src/components/ai-edition/*, src/i18n/locales/*, src/lib/compositeLayout.ts, docs/*, crates/fixture/*		 The removed controls, preview frame fitting, obsolete translation keys, retired fixtures, and the 3D-effects specification are deleted. The manual checklist now covers fixed rotation presets.

Estimated code review effort: 5 (Critical) | ~90 minutes

Suggested reviewers: my-denia

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.0)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit bfafd20 into main Sep 17, 2026
18 of 19 checks passed
@EtienneLescot
EtienneLescot deleted the revert/3d-effects-untested branch September 17, 2026 18:19
@EtienneLescot EtienneLescot mentioned this pull request Sep 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Beetix Beetix Awaiting requested review from Beetix Beetix is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EtienneLescot