ci: bump pinned GitHub Actions to their Node 24 majors#97
Open
EtienneLescot wants to merge 1 commit into
Open
Conversation
Every workflow run was logging: Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4 ... GitHub Actions is dropping the Node 20 shim; these actions still declared `using: node20` at the pinned majors, so runners were silently forcing them onto Node 24 anyway. Bump to the majors that declare `using: node24` natively (verified via each repo's action.yml at the release tag): actions/checkout v4 -> v7 actions/setup-node v4 -> v7 actions/setup-python v5 -> v6 actions/cache v4 -> v6 actions/upload-artifact v4 -> v7 actions/download-artifact v4 -> v8 Checked every major's release notes for breaking changes against how this repo actually uses them (by name, not artifact-id; no exotic checkout options) - none apply. download-artifact's v5 path-behavior change only affects by-ID downloads, which this repo doesn't use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughUpdates GitHub Actions versions across the composite setup action and CI, build, release, diagnostic, notification, and maintenance workflows while preserving existing commands, artifact handling, and publishing logic. ChangesGitHub Actions upgrades
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every workflow run logs:
GitHub is dropping the Node 20 shim. These actions still declare
using: node20at the pinned majors in this repo, so runners are already silently forcing them onto Node 24 — this is a warning today, a hard break later.Fix
Bump each action to the major that declares
using: node24natively (verified directly against each repo'saction.ymlat the release tag, not just changelog claims):actions/checkoutactions/setup-nodeactions/setup-pythonactions/cacheactions/upload-artifactactions/download-artifactApplied across all 11 workflow/composite-action files that reference them.
Breaking changes checked
Read the release notes for every intermediate major and checked each against how this repo actually calls these actions:
name:, neverartifact-id, so unaffected.package.json#packageManager. This repo's composite action already setscache: npmexplicitly, so no behavior change.archive: falsefor direct uploads) that nothing here uses.No other breaking change applies to this repo's usage.
Note on the diff
ci.ymlwas the one workflow file with CRLF line endings (an existing inconsistency, not introduced here). Restored CRLF after editing so the diff is the 4 actual version bumps, not a 130-line line-ending rewrite.🤖 Generated with Claude Code
Summary by CodeRabbit