feat(status): probe Statuspage summary directly instead of host heuristic - #1510
Merged
Conversation
…stic
Replace the loose domain-name heuristic (host.includes("status"),
endsWith(".statuspage.io")) with a direct probe: request
/api/v2/summary.json and use it only when the response is a valid
Statuspage summary, otherwise fall back to the self-hosted
/_health/?full=1 probe. This eliminates host mis-classification and makes
`sentry status` reliable for arbitrary self-hosted or regional
deployments.
Fixes #1509
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
marked this pull request as ready for review
September 4, 2026 09:45
Member
|
Jared, get the CI green |
Contributor
Author
|
fix-ci: attempt 1 — 2 new silent catches in status-page.ts flagged by check:errors (the probe-first implementation added bare catch { return; } blocks) |
Contributor
Author
|
CI green after adding log.debug on the two Statuspage probe fallbacks (check:errors now passes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #1494 addressing BYK's request in #1494 (comment) to stop inferring Statuspage instances from the host name.
what changed
fetchSentryStatusno longer guesses from the hostname whether a URL is a Statuspage instance. instead it probes the target directly:<url>/api/v2/summary.jsonstatus.indicator, treat it as a real Statuspage summary and use it/_health/?full=1probeno more
host.includes("status")/.statuspage.ioinference, so arbitrary self-hosted or regional deployments classify correctly.testing
vitest run test/lib/api/status-page test/commands/status— 11 tests pass (probe-first success on default and arbitrary hosts, 404/non-JSON/non-Statuspage fallbacks, health-probe major/network-error paths)tsc --noEmitcleanbiome checkclean on changed filesCloses #1509