Skip to content

Merge main into 8.x.x with 7.20.0 being latest release - #4033

Merged
adinauer merged 7 commits into
8.x.xfrom
feat/merge-main-jan-2025
Jan 9, 2025
Merged

Merge main into 8.x.x with 7.20.0 being latest release#4033
adinauer merged 7 commits into
8.x.xfrom
feat/merge-main-jan-2025

Conversation

@adinauer

@adinauer adinauer commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

#skip-changelog

📜 Description

Merge main into 8.x.x with 7.20.0 being latest release

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@github-actions

github-actions Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c34b5b7

@github-actions

github-actions Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.15 ms 516.33 ms 89.18 ms
Size 1.65 MiB 2.31 MiB 677.52 KiB

Previous results on branch: feat/merge-main-jan-2025

Startup times

Revision Plain With Sentry Diff
9c294ec 425.75 ms 461.96 ms 36.21 ms

App size

Revision Plain With Sentry Diff
9c294ec 1.65 MiB 2.31 MiB 677.64 KiB

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

romtsn
romtsn approved these changes Jan 8, 2025
View reviewed changes

@romtsn romtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the replay changes ✅

@github-actions

github-actions Bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

stefanosiano
stefanosiano approved these changes Jan 9, 2025
View reviewed changes

@stefanosiano stefanosiano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the other changes

@github-actions

github-actions Bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java
  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@adinauer
adinauer merged commit cb4efff into 8.x.x Jan 9, 2025
@adinauer
adinauer deleted the feat/merge-main-jan-2025 branch January 9, 2025 14:44
@runningcode runningcode mentioned this pull request Jul 30, 2026
Merged
8 tasks
runningcode added a commit that referenced this pull request Jul 30, 2026
@runningcode @claude
ref(android): Remove unused lock from SentryPerformanceProvider (#5871)
337a9f1 
* ref(android): Remove unused lock from SentryPerformanceProvider

The field was added in #3715 to guard onAppStartDone(), its only user. That
method was removed in the 8.x.x merge (#4033), leaving the lock orphaned — it
has been allocated on every cold start since, in ContentProvider.onCreate,
without ever being acquired.

The ISentryLifecycleToken import stays: it is still used for
AppStartMetrics.staticLock in shutdown().

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* changelog

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes
@markushi markushi Awaiting requested review from markushi
+1 more reviewer
@stefanosiano stefanosiano stefanosiano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @romtsn @stefanosiano