Skip to content

Add origin to logs#4618

Merged
adinauer merged 4 commits into
mainfrom
08-07-add_origin_to_logs
Aug 8, 2025
Merged

Add origin to logs#4618
adinauer merged 4 commits into
mainfrom
08-07-add_origin_to_logs

Conversation

@adinauer

@adinauer adinauer commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Sends the sentry.origin attribute to Sentry.
For integrations this is set to e.g. sentry.log.logcat, sentry.log.logback, ...
The default is manual.

💡 Motivation and Context

So we know what's creating logs.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer
adinauer marked this pull request as ready for review August 7, 2025 14:19
@adinauer Graphite App

adinauer commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@adinauer
adinauer force-pushed the 08-07-add_origin_to_logs branch from 8feaf5a to dfbdbe5 Compare August 7, 2025 14:23
@adinauer
adinauer force-pushed the 08-07-add_origin_to_logs branch from dfbdbe5 to 93ff861 Compare August 7, 2025 14:27
@adinauer

adinauer commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

@sentry review

@adinauer

adinauer commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

cursor review

cursor[bot]

This comment was marked as outdated.

Sign in to view

romtsn
romtsn approved these changes Aug 7, 2025
View reviewed changes

@romtsn romtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

seer-by-sentry[bot]
seer-by-sentry Bot reviewed Aug 7, 2025
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/logger/SentryLogParameters.java
seer-by-sentry[bot]
seer-by-sentry Bot reviewed Aug 7, 2025
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/logger/LoggerApi.java
@github-actions

github-actions Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.51 ms 465.47 ms 42.96 ms
Size 1.58 MiB 2.09 MiB 522.31 KiB

Previous results on branch: 08-07-add_origin_to_logs

Startup times

Revision Plain With Sentry Diff
8c9b73e 433.98 ms 480.59 ms 46.61 ms
c8b0567 419.61 ms 480.96 ms 61.35 ms

App size

Revision Plain With Sentry Diff
8c9b73e 1.58 MiB 2.09 MiB 522.31 KiB
c8b0567 1.58 MiB 2.09 MiB 522.31 KiB

@adinauer
adinauer merged commit f2b0ffb into main Aug 8, 2025
36 of 37 checks passed
@adinauer
adinauer deleted the 08-07-add_origin_to_logs branch August 8, 2025 11:58
@antonis antonis mentioned this pull request Aug 11, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments
@romtsn romtsn romtsn approved these changes
@lcian lcian lcian approved these changes
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes
@stefanosiano stefanosiano Awaiting requested review from stefanosiano
@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adinauer @romtsn @lcian @alexander-alderman-webb