Skip to content

fix: dead member, capacity checks, insert perf, napi_env by value #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasBa merged 2 commits into from
Apr 30, 2026
Merged

fix: dead member, capacity checks, insert perf, napi_env by value #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b934c3
fix: dead member, fragile capacity checks, insert perf, and napi_env …
JonasBa Apr 30, 2026
b38f3e8
style: apply clang-format
JonasBa Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions bindings/cpu_profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <unordered_map>

static const uint8_t kMaxStackDepth(128);
static const uint16_t kMaxMeasurementSamples(300);
static const float kSamplingFrequency(99.0); // 99 to avoid lockstep sampling
static const float kSamplingHz(1 / kSamplingFrequency);
static const int kSamplingInterval(kSamplingHz * 1e6);
Expand Down Expand Up @@ -82,7 +83,6 @@ class MeasurementsTicker {
cpu_listeners;
v8::Isolate *isolate;
v8::HeapStatistics heap_stats;
uv_cpu_info_t cpu_stats;

public:
MeasurementsTicker(uv_loop_t *loop)
Expand Down Expand Up @@ -161,7 +161,7 @@ void MeasurementsTicker::remove_heap_listener(

// CPU tickers
void MeasurementsTicker::cpu_callback() {
uv_cpu_info_t *cpu = &cpu_stats;
uv_cpu_info_t *cpu = nullptr;
int count;
int err = uv_cpu_info(&cpu, &count);

Expand Down Expand Up @@ -245,7 +245,7 @@ class Profiler {
MeasurementsTicker measurements_ticker;
v8::CpuProfiler *cpu_profiler;

explicit Profiler(const napi_env &env, v8::Isolate *isolate)
explicit Profiler(napi_env env, v8::Isolate *isolate)
: measurements_ticker(uv_default_loop()),
cpu_profiler(
v8::CpuProfiler::New(isolate, kNamingMode, GetLoggingMode())) {}
Expand Down Expand Up @@ -274,39 +274,33 @@ class SentryProfile {
explicit SentryProfile(const char *id)
: started_at(uv_hrtime()), timestamp(timestamp_milliseconds()),
memory_sampler_cb([this](uint64_t ts, v8::HeapStatistics &stats) {
if ((heap_write_index >= heap_stats_ts.capacity()) ||
heap_write_index >= heap_stats_usage.capacity()) {
if (heap_write_index >= kMaxMeasurementSamples) {
return true;
}

heap_stats_ts.insert(heap_stats_ts.begin() + heap_write_index,
ts - started_at);
heap_stats_usage.insert(
heap_stats_usage.begin() + heap_write_index,
heap_stats_ts.push_back(ts - started_at);
heap_stats_usage.push_back(
static_cast<uint64_t>(stats.used_heap_size()));
++heap_write_index;

return false;
}),

cpu_sampler_cb([this](uint64_t ts, double rate) {
if (cpu_write_index >= cpu_stats_ts.capacity() ||
cpu_write_index >= cpu_stats_usage.capacity()) {
if (cpu_write_index >= kMaxMeasurementSamples) {
return true;
}
cpu_stats_ts.insert(cpu_stats_ts.begin() + cpu_write_index,
ts - started_at);
cpu_stats_usage.insert(cpu_stats_usage.begin() + cpu_write_index,
rate);
cpu_stats_ts.push_back(ts - started_at);
cpu_stats_usage.push_back(rate);
++cpu_write_index;
return false;
}),

status(ProfileStatus::kNotStarted), id(id) {
heap_stats_ts.reserve(300);
heap_stats_usage.reserve(300);
cpu_stats_ts.reserve(300);
cpu_stats_usage.reserve(300);
heap_stats_ts.reserve(kMaxMeasurementSamples);
heap_stats_usage.reserve(kMaxMeasurementSamples);
cpu_stats_ts.reserve(kMaxMeasurementSamples);
cpu_stats_usage.reserve(kMaxMeasurementSamples);
}

const std::vector<uint64_t> &heap_usage_timestamps() const;
Expand Down Expand Up @@ -479,7 +473,7 @@ static napi_value GetFrameModuleWrapped(napi_env env, napi_callback_info info) {
}

napi_value
CreateFrameNode(const napi_env &env, const v8::CpuProfileNode &node,
CreateFrameNode(napi_env env, const v8::CpuProfileNode &node,
std::unordered_map<std::string, std::string> &module_cache,
napi_value &resources) {
napi_value js_node;
Expand Down Expand Up @@ -546,7 +540,7 @@ CreateFrameNode(const napi_env &env, const v8::CpuProfileNode &node,
return js_node;
};

napi_value CreateSample(const napi_env &env, const enum ProfileFormat format,
napi_value CreateSample(napi_env env, const enum ProfileFormat format,
const uint32_t stack_id,
const int64_t sample_timestamp_ns,
const double chunk_timestamp,
Expand Down Expand Up @@ -594,7 +588,7 @@ std::string hashCpuProfilerNodeByPath(const v8::CpuProfileNode *node,
return path;
}

static void GetSamples(const napi_env &env, const v8::CpuProfile *profile,
static void GetSamples(napi_env env, const v8::CpuProfile *profile,
ProfileFormat format,
const uint64_t profile_start_timestamp_ms,
const uint32_t thread_id, napi_value &samples,
Expand Down Expand Up @@ -712,7 +706,7 @@ static void GetSamples(const napi_env &env, const v8::CpuProfile *profile,
}

static napi_value TranslateMeasurementsDouble(
const napi_env &env, const enum ProfileFormat format, const char *unit,
napi_env env, const enum ProfileFormat format, const char *unit,
const uint64_t profile_start_timestamp_ms, const uint16_t size,
const std::vector<double> &values,
const std::vector<uint64_t> &timestamps_ns) {
Expand Down Expand Up @@ -775,7 +769,7 @@ static napi_value TranslateMeasurementsDouble(
}

static napi_value
TranslateMeasurements(const napi_env &env, const enum ProfileFormat format,
TranslateMeasurements(napi_env env, const enum ProfileFormat format,
const char *unit,
const uint64_t profile_start_timestamp_ms,
const uint16_t size, const std::vector<uint64_t> &values,
Expand Down Expand Up @@ -835,8 +829,7 @@ TranslateMeasurements(const napi_env &env, const enum ProfileFormat format,
return measurement;
}

static napi_value TranslateProfile(const napi_env &env,
const v8::CpuProfile *profile,
static napi_value TranslateProfile(napi_env env, const v8::CpuProfile *profile,
const enum ProfileFormat format,
const uint64_t profile_start_timestamp_ms,
const uint32_t thread_id,
Expand Down
Loading