Skip to content

Align remaining denoHttpIntegration options with httpIntegration #23481

Description

@RulaKhaled

Follow-up to #23313 (aligned most of denoHttpIntegration's option names with httpIntegration). Remaining todos:

  • Outgoing request hooks missing in Deno. outgoingRequestHook and outgoingResponseHook already match core's names, so declaring them is enough now that options are spread through.
    • Open question: only applyCustomAttributesOnSpan diverges. Use core's name, or match Node's outgoingRequestApplyCustomAttributes (needs explicit mapping, like tracePropagation→propagateTrace)?
  • ignoreStatusCodes is a no-op in Deno. declared on HttpInstrumentationOptions but only implemented in Node's httpServerSpansIntegration.processEvent.
    • Fix: move shouldFilterStatusCode into @sentry/core for both to share, or give Deno its own processEvent. Either way, don't leave it declared-but-unread on the shared contract.
  • onSpanEnd asymmetry. Deno has it, Node doesn't, though core's server subscription supports it. Better to add it to httpIntegration than remove it from Deno.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions