Skip to content

Port Node server framework E2E test apps to span streaming #23800

Description

@andreiborza

Port these E2E test applications to span streaming (18 apps).

Apps

  • effect-3-node
  • effect-4-node
  • elysia-node
  • hono-4
  • node-express
  • node-express-esm-loader
  • node-express-esm-without-loader
  • node-express-mcp-v2
  • node-express-send-to-sentry
  • node-express-v5
  • node-fastify-3
  • node-fastify-4
  • node-fastify-5
  • node-firebase
  • node-hapi
  • node-koa
  • node-profiling-electron
  • tsx-express

What to do

For each app:

  1. Remove the traceLifecycle: 'static' pin added in test(e2e): Disable span streaming in e2e test applications #22590 from every Sentry.init (client, server, edge).
  2. Rewrite the specs from transaction envelopes to span v2:
    • waitForTransaction becomes waitForStreamedSpan / waitForStreamedSpans
    • event.transaction becomes span.name
    • contexts.trace.op becomes getSpanOp(span) plus span.is_segment
    • contexts.trace.data['x'] becomes span.attributes['x'], which has the shape { value, type }
    • transaction_info.source becomes the sentry.segment.name.source attribute
  3. Streamed child spans arrive across several envelopes, so use collectStreamedSpans wherever a test asserts on children of a segment span.

This group is the most affected by the low-cardinality span name work: http.server, http.client, router, request handler, db and messaging span names all change under streaming. Expect to rewrite name assertions, not just swap the helper.

Reference app: nextjs-16-streaming. Worked example: #23797.

Keep static trace lifecycle coverage

Before porting this group, duplicate node-express as-is into node-express-static and leave that copy on the current transaction-based specs. That keeps the static trace lifecycle covered once the rest of the group moves to streaming.

The copy is verbatim; only the app name changes:

  • package.json -> name
  • start-event-proxy.mjs -> proxyServerName
  • every waitForTransaction / waitForError / waitForSession call in tests/

Keep traceLifecycle: 'static' in the copy's Sentry.init calls. The e2e matrix discovers apps by directory, so no CI config change is needed.

The representative is a suggestion: swap it if another app in the list exercises more of this SDK's instrumentation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

TaskjavascriptPull requests that update javascript code

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions