fix(nextjs): Apply Webpack configuration in dev mode#6291
Merged
Conversation
AbhiPrasad
reviewed
Nov 24, 2022
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can we test this?
Also needs a quick release I assume?
Contributor
Author
We don't have a test setup for dev mode. I don't consider it worth the effort. Doesn't need to be released immediately IMO. It only affects dev mode so most production systems should be unaffected. |
AbhiPrasad
approved these changes
Nov 24, 2022
Contributor
size-limit report 📦
|
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6284
This PR fixes that our Webpack configuration didn't get picked up in dev mode.