test(integration-tests): Unflake some tests - #7076
Merged
Merged
Conversation
added 2 commits
February 7, 2023 14:38
lforst
changed the title
backgroundtab-pageload
lforst
marked this pull request as ready for review
February 7, 2023 15:16
Contributor
Author
|
Gonna re-run this a bunch of times to see if it worked |
Contributor
|
I'll make a flaky test issue! Edit: #7079 |
AbhiPrasad
reviewed
Feb 7, 2023
Comment on lines
+14
to
+16
| await page.click('#go-background'); | ||
|
|
||
| const pageloadTransaction = await pageloadTransactionPromise; |
Contributor
There was a problem hiding this comment.
Can we just Promise.all (kicking off the page click first?)?
Contributor
Author
There was a problem hiding this comment.
That is inherently gonna produce the race condition again that I want to remove with this change. Listen first -> then the interaction -> wait for interaction outcome. Mixing step 1 and 2 is dangerous.
AbhiPrasad
approved these changes
Feb 7, 2023
Lms24
approved these changes
Feb 7, 2023
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Desperately need this, thanks 🙏
This was referenced Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dunno if the changes to the backgroundtab changes actually do something but Id say it is worth a try.