fix(replay): Move error sampling to before send - #8057
Merged
mydea merged 5 commits intoMay 8, 2023
Merged
Conversation
billyvg
changed the title
billyvg
marked this pull request as ready for review
May 5, 2023 21:34
Contributor
size-limit report 📦
|
In buffer mode, we were always tagging error events even if it was not sampled. This is because the sampling decision was moved from the initialization of the SDK to much further down the pipeline to right before flushing a replay. We now handle sampling of the error event before tagging event with replayId, and in the afterSend callback, we consider an error event as sampled if it has a replayId.
billyvg
force-pushed
the
fix-replay-sampling-happens-too-late-incorrect-tagging
branch
from
May 5, 2023 22:38
9d724a3 to
1319822
Compare
mydea
reviewed
May 8, 2023
| return; | ||
| } | ||
|
|
||
| if (replay.recordingMode === 'buffer' && event.tags && event.tags.replayId) { |
Member
There was a problem hiding this comment.
I love this, much clearer than before! 🎉
Member
|
I was so free to do a very minor refactor (I combined |
mydea
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In buffer mode, we were always tagging error events even if it was not sampled. This is because the sampling decision was moved from the initialization of the SDK to much further down the pipeline to right before flushing a replay. We now handle sampling of the error event before tagging event with replayId, and in the afterSend callback, we consider an error event as sampled if it has a replayId.
Closes #8055