Skip to content

ref(replay): Capture parametrized route - #8095

Merged
mydea merged 1 commit into
developfrom
fn/replay-parametrized-route
Jun 1, 2023
Merged

ref(replay): Capture parametrized route#8095
mydea merged 1 commit into
developfrom
fn/replay-parametrized-route

Conversation

@mydea

@mydea mydea commented May 10, 2023

Copy link
Copy Markdown
Member

This is a draft of capturing the current parametrized route for Replay. We'll want to have that for slow click capturing, but maybe also at other places... this is only available when performance is used.

Feel free to adjust/merge/close this when needed.

@github-actions

github-actions Bot commented May 10, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.05 KB (+0.13% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.69 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.16 KB (+0.14% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.21 KB (+0.18% 🔺)
@sentry/browser - Webpack (minified) 69.08 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.23 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.16 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.67 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.91 KB (+0.11% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.58 KB (+2.03% 🔺)
@sentry/replay - Webpack (gzipped + minified) 42.28 KB (+1.97% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.57 KB (+1.61% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.47 KB (+1.83% 🔺)

Comment thread packages/replay/src/replay.ts Outdated
@mydea
mydea force-pushed the fn/replay-parametrized-route branch 2 times, most recently from c475437 to 9f57b5c Compare May 10, 2023 14:41
@cmanallen

Copy link
Copy Markdown
Member

Related: getsentry/sentry#48259

@cmanallen

cmanallen commented May 11, 2023

Copy link
Copy Markdown
Member

@billyvg Franceso's out for the next two weeks. Do you want to take over (only if you have availability and we think it could help with fingerprinting)?

@mydea
mydea force-pushed the fn/replay-parametrized-route branch from 9f57b5c to d823206 Compare June 1, 2023 07:20
@mydea
mydea marked this pull request as ready for review June 1, 2023 07:20
@mydea
mydea merged commit d5551aa into develop Jun 1, 2023
@mydea
mydea deleted the fn/replay-parametrized-route branch June 1, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants