chore(profiling): Move profiling types to types and cache to utils - #8270
Merged
Conversation
krystofwoldrich
requested review from
JonasBa,
Lms24,
lobsterkatie and
marandaneto
June 1, 2023 11:57
9 tasks
Contributor
size-limit report 📦
|
Contributor
|
@krystofwoldrich changes make sense to me, this used to just live in browser profiling as it was the only place that it was used in. Will let other JS maintainers make the final call here |
AbhiPrasad
reviewed
Jun 5, 2023
AbhiPrasad
left a comment
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
yeah good idea on extracting this stuff out!
AbhiPrasad
approved these changes
Jun 19, 2023
Contributor
Can we work on removing usage of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).I've moved some profiling code so it's possible to share it with RN.
I've added
transactionto the profile as here in JS profile contains onlytransactionsarray.Also added some profile sub-types (sample, frame, stack) so they can be used separately.
Also added yalc publish to the hub package, since it's used in RN and useful for local tests of the changes.