test(e2e): Add create-remix-app test - #8286
Merged
Merged
Conversation
priscilawebdev
marked this pull request as ready for review
June 4, 2023 15:26
Contributor
size-limit report 📦
|
Member
Author
|
|
Member
You need to run |
priscilawebdev
enabled auto-merge
July 6, 2023 06:38
lforst
approved these changes
Jul 6, 2023
lforst
left a comment
lforst
left a comment
Contributor
There was a problem hiding this comment.
Other than the two small comments this looks good to me! :) Thanks!
Contributor
There was a problem hiding this comment.
We don't need lockfiles in the e2e tests!
Contributor
There was a problem hiding this comment.
Let's get rid of the favicon as it is not really necessary to any tests!
lforst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces the 'create remix' app to our end-to-end (e2e) tests. Currently, the focus is on validating if the build passes using the latest version of our remix SDK. However, in the future, we can extend these tests to encompass additional scenarios such as verifying exception handling, transaction processing, and more.
The primary goal of this PR is to prevent the release of our remix's SDK packages with ESM-related errors, such as the one mentioned in GitHub issue #5351