Skip to content

feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay - #8439

Merged
mydea merged 4 commits into
getsentry:developfrom
ziyad-elabid-nw:feat/add-network-details-exclude-urls
Jul 4, 2023
Merged

feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay#8439
mydea merged 4 commits into
getsentry:developfrom
ziyad-elabid-nw:feat/add-network-details-exclude-urls

Conversation

@ziyad-elabid-nw

@ziyad-elabid-nw ziyad-elabid-nw commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@ziyad-elabid-nw

ziyad-elabid-nw commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

In this PR, i added a new option networkDetailDenyUrls to Replay.

As a Sentry user it will help me a lot, when using both networkDetailDenyUrls and networkDetailAllowUrls together, we can achieve more fine-grained control over which URLs to include or exclude when capturing network details.

Related to this issue : #8435

@ziyad-elabid-nw
ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch 3 times, most recently from 35b0909 to 5fa1d8b Compare July 1, 2023 09:35
@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls feat(replay): Add a new option NetworkDetailExcludeUrls to Replay Jul 1, 2023
@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls to Replay feat(replay): Add a new option NetworkDetailExcludeUrls to Sentry Replay Jul 1, 2023
mydea
mydea approved these changes Jul 3, 2023
View reviewed changes

@mydea mydea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this seems good to me! I'll wait for @billyvg to also have a look (tomorrow), but IMHO this seems ready to go.

@mydea mydea self-assigned this Jul 3, 2023
@ziyad-elabid-nw
ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 5fa1d8b to 963982e Compare July 3, 2023 08:26
@ziyad-elabid-nw

ziyad-elabid-nw commented Jul 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks a lot, this seems good to me! I'll wait for @billyvg to also have a look (tomorrow), but IMHO this seems ready to go.

Thanks, i've just fixed the browser unit tests 💯

billyvg
billyvg reviewed Jul 3, 2023
View reviewed changes

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea @ziyad-elabid-nw Should we maybe name this networkDetailDenyUrls to match the -AllowUrls?

@ziyad-elabid-nw

ziyad-elabid-nw commented Jul 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mydea @ziyad-elabid-nw Should we maybe name this networkDetailDenyUrls to match the -AllowUrls?

Agreed, it makes more sense than networkDetailExcludeUrls in this case 👍 i'll do the changes

@ziyad-elabid-nw

ziyad-elabid-nw commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

Done 👍

@ziyad-elabid-nw
ziyad-elabid-nw requested review from billyvg and mydea July 3, 2023 22:14
@ziyad-elabid-nw ziyad-elabid-nw changed the title feat(replay): Add a new option NetworkDetailExcludeUrls to Sentry Replay feat(replay): Add a new option NetworkDetailDenyUrls to Sentry Replay Jul 3, 2023
@ziyad-elabid-nw
ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 9f0ce30 to 03cb275 Compare July 4, 2023 07:54
@ziyad-elabid-nw
ziyad-elabid-nw force-pushed the feat/add-network-details-exclude-urls branch from 03cb275 to 3419e90 Compare July 4, 2023 08:03
@mydea
mydea merged commit 9ede8a3 into getsentry:develop Jul 4, 2023
@mydea mydea changed the title feat(replay): Add a new option NetworkDetailDenyUrls to Sentry Replay feat(replay): Add a new option networkDetailDenyUrls to Sentry Replay Jul 4, 2023
@hi019

hi019 commented Jul 4, 2023

Copy link
Copy Markdown

Thanks for this! Is there an ETA on when this PR will make it into a release?

@mydea

mydea commented Jul 5, 2023

Copy link
Copy Markdown
Member

We'll cut a release this week or at the latest next week probably, so shouldn't be too long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes
@mydea mydea mydea approved these changes
@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ziyad-elabid-nw @hi019 @mydea @billyvg