ref: Extract error tree walking logic for LinkedErrors integrations - #8455
Merged
Conversation
lforst
changed the title
LinkedErrors integrationLinkedErrors integrations
Contributor
size-limit report 📦
|
lforst
force-pushed
the
lforst-unify-linked-errors
branch
from
July 5, 2023 11:00
1598a7a to
91beac3
Compare
added 2 commits
July 5, 2023 17:32
lforst
marked this pull request as ready for review
July 5, 2023 16:04
AbhiPrasad
changed the title
LinkedErrors integrationsLinkedErrors integrations
AbhiPrasad
reviewed
Jul 5, 2023
AbhiPrasad
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #5469
Extracts the Error tree walking logic out of the two
LinkedErrorsintegrations (node, browser) into the utils package.Also adds a bit more streamlined tests for that function and removes the tests for the integrations because they were essentially just duplicated.