feat(sanic): Support span streaming by sl0thentr0py · Pull Request #6319 · getsentry/sentry-python

sl0thentr0py · 2026-05-21T12:56:14Z

The _unsampled_statuses option is not respected for span streaming since we currently don't allow tail-based sampling in the new system.

Issues

resolves: Migrate sanic to span first #6055
resolves: PY-2357

linear-code · 2026-05-21T12:57:35Z

PY-2357

github-actions · 2026-05-21T12:58:06Z

Codecov Results 📊

✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 40.11s

All tests are passing successfully.

❌ Patch coverage is 9.52%. Project has 15310 uncovered lines.

Files with missing lines (1)

File	Patch %	Lines
`sanic.py`	9.35%	⚠️ 194 Missing

Generated by Codecov Action

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d10461b. Configure here.}

The `_unsampled_statuses` option is not respected for span streaming since we currently don't allow tail-based sampling in the new system.

ericapisani

Some small things but otherwise LGTM. Approving so as not to block it from merging

ericapisani · 2026-05-21T18:34:57Z

+                    span.set_attribute(SPANDATA.HTTP_STATUS_CODE, response_status)
+                    span.status = "error" if response_status >= 400 else "ok"
+
+                span._end()


We have a public end method that we can use here instead of the private _end (and the public method calls _end under the hood giving us the same outcome)

ericapisani · 2026-05-21T18:39:50Z

+    if urlparts.query:
+        attributes[SPANDATA.HTTP_QUERY] = urlparts.query
+
+    attributes[SPANDATA.URL_FULL] = request.url


This appears to now be treated as PII, so would need to also be gated behind should_send_default_pii()

I think the PII designation in conventions is enforced in Relay and not the SDK

ericapisani · 2026-05-21T18:44:42Z

+            i.payload
+            for i in items
+            if i.type == "span"
+            and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"


Because this is specifically looking for segments, this filter may be too broad since any child span originating from the integration would be returned. To be safe, it might be worth adding a check on the _is_segment property and confirming that it's True

sentrivana · 2026-05-22T08:31:32Z

+                    span.set_attribute(SPANDATA.HTTP_STATUS_CODE, response_status)
+                    span.status = "error" if response_status >= 400 else "ok"
+
+                span._end()


Suggested change

span._end()

span.end()

sentrivana

Looks good, couple small things _end -> end and TransactionSource -> SegmentSource

sentrivana · 2026-05-22T08:32:41Z

        with capture_internal_exceptions():
            scope = sentry_sdk.get_current_scope()
            route_name = route.name.replace(request.app.name, "").strip(".")
            scope.set_transaction_name(route_name, source=TransactionSource.COMPONENT)


There's a SegmentSource too for the streaming path. Would be good to use that if span streaming is enabled

sentrivana · 2026-05-22T08:33:19Z

                    sanic_route = sanic_route[len(sanic_app_name) + 1 :]

                scope.set_transaction_name(
                    sanic_route, source=TransactionSource.COMPONENT


Here too we should do SegmentSource if streaming

sentrivana · 2026-05-22T08:33:26Z

                )
            else:
                scope.set_transaction_name(
                    rv[0].__name__, source=TransactionSource.COMPONENT


sentrivana · 2026-05-22T08:36:20Z

+            if i.type == "span"
+            and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"


If you do capture_items("span"), there won't be anything but spans in the list, so no need to check explicitly

Suggested change

if i.type == "span"

and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

if i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

sentrivana · 2026-05-22T08:36:59Z

+            if i.type == "span"
+            and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"


Suggested change

if i.type == "span"

and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

if i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

sl0thentr0py requested a review from a team as a code owner May 21, 2026 12:56

sl0thentr0py force-pushed the neel/span-first/sanic branch from d266281 to 950a311 Compare May 21, 2026 13:00

sentry-warden Bot reviewed May 21, 2026

View reviewed changes

Comment thread tests/integrations/sanic/test_sanic.py

sentry-warden Bot reviewed May 21, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/sanic.py Outdated

sl0thentr0py force-pushed the neel/span-first/sanic branch 2 times, most recently from ca346f8 to d10461b Compare May 21, 2026 13:27

cursor Bot reviewed May 21, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/sanic.py Outdated

sl0thentr0py force-pushed the neel/span-first/sanic branch from d10461b to 9e8d40b Compare May 21, 2026 13:48

sentry-warden Bot reviewed May 21, 2026

View reviewed changes

Comment thread sentry_sdk/traces.py Outdated

sl0thentr0py force-pushed the neel/span-first/sanic branch from 9e8d40b to e9d3bf6 Compare May 21, 2026 14:14

feat(sanic): Support span streaming

0f32453

The `_unsampled_statuses` option is not respected for span streaming since we currently don't allow tail-based sampling in the new system.

sl0thentr0py force-pushed the neel/span-first/sanic branch from e9d3bf6 to 0f32453 Compare May 21, 2026 14:16

ericapisani reviewed May 21, 2026

View reviewed changes

sentrivana reviewed May 22, 2026

View reviewed changes

sentrivana approved these changes May 22, 2026

View reviewed changes

sentrivana reviewed May 22, 2026

View reviewed changes

sentrivana added the skip-changelog label May 22, 2026

		if i.type == "span"
		and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

	if i.type == "span"
	and i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"
	if i.payload["attributes"].get("sentry.origin") == "auto.http.sanic"

Conversation

sl0thentr0py commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Uh oh!

linear-code Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ericapisani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sl0thentr0py commented May 21, 2026 •

edited

Loading

github-actions Bot commented May 21, 2026 •

edited

Loading