Skip to content

fix: Do not let exceptions in before_breadcrumb bubble up - #7133

Merged
sentrivana merged 1 commit into
masterfrom
ivana/before-breadcrumb-guard
Aug 7, 2026
Merged

fix: Do not let exceptions in before_breadcrumb bubble up#7133
sentrivana merged 1 commit into
masterfrom
ivana/before-breadcrumb-guard

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

If there's a problem in before_breadcrumb, it could take down the whole app.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

99265 passed | ⏭️ 6479 skipped | Total: 105744 | Pass Rate: 93.87% | Execution Time: 355m 11s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +15
Passed Tests 📈 +16
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_trace_decorator_no_trx
    • File: tests.tracing.test_decorator

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2500 uncovered lines.
✅ Project coverage is 90.02%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.99%    90.02%    +0.03%
==========================================
  Files          193       193         —
  Lines        24974     25048       +74
  Branches      9008      9036       +28
==========================================
+ Hits         22473     22548       +75
- Misses        2501      2500        -1
- Partials      1437      1442        +5

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review August 7, 2026 09:39
@sentrivana
sentrivana requested a review from a team as a code owner August 7, 2026 09:39
@sentrivana
sentrivana force-pushed the ivana/before-breadcrumb-guard branch from 1edae07 to 25d07de Compare August 7, 2026 09:42
@sentrivana
sentrivana changed the base branch from ivana/move-http-client-breadcrumbs-1 to master August 7, 2026 09:42
@sentrivana
sentrivana enabled auto-merge (squash) August 7, 2026 09:44
@sentrivana
sentrivana merged commit 446a1d5 into master Aug 7, 2026
138 checks passed
@sentrivana
sentrivana deleted the ivana/before-breadcrumb-guard branch August 7, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants