Skip to content

chore(bottle): Remove transaction code - #7272

Draft
sentrivana wants to merge 1 commit into
major/3.0from
ivana/major/remove-transactions-from-bottle
Draft

chore(bottle): Remove transaction code#7272
sentrivana wants to merge 1 commit into
major/3.0from
ivana/major/remove-transactions-from-bottle

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

This should not be needed anymore.

@sentrivana
sentrivana force-pushed the ivana/major/remove-transactions-from-trytond-wsgi branch 3 times, most recently from 832e83e to 46fe396 Compare August 27, 2026 12:08
@sentrivana
sentrivana changed the base branch from ivana/major/remove-transactions-from-trytond-wsgi to major/3.0 August 27, 2026 12:09
@sentrivana
sentrivana force-pushed the ivana/major/remove-transactions-from-bottle branch from 4e951ab to 0633083 Compare August 27, 2026 12:10
@sentrivana
sentrivana marked this pull request as ready for review August 27, 2026 12:13
@sentrivana
sentrivana requested a review from a team as a code owner August 27, 2026 12:13

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0633083. Configure here.

name = ""

if transaction_style == "url":
try:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Events lose Bottle route names

High Severity

Removing _set_transaction_name_and_source from the request event processor means error and message events no longer get the Bottle route name. _set_segment_name_and_source only runs after the handler returns, so events captured during the request keep the generic WSGI name instead of the matched route.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0633083. Configure here.

@sentrivana
sentrivana marked this pull request as draft August 27, 2026 12:23
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

110960 passed | ⏭️ 5428 skipped | Total: 116388 | Pass Rate: 95.34% | Execution Time: 384m 20s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -5326
Passed Tests 📉 -4019
Failed Tests 📉 -3
Skipped Tests 📉 -1304

➖ Removed Tests (2)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm
  • test_cache_spans_item_size[True]
    • File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2250 uncovered lines.
✅ Project coverage is 90.57%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.57%    +0.33%
==========================================
  Files          193       185        -8
  Lines        25480     23864     -1616
  Branches      9382      8798      -584
==========================================
+ Hits         22994     21614     -1380
- Misses        2486      2250      -236
- Partials      1431      1366       -65

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant