fix(ios): Preserve Info.plist preprocessing for auto-release detection#6211
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
CLI 3.4.3 disables Xcode Info.plist preprocessing by default. Add --allow-xcode-infoplist-preprocessing to sentry-xcode.sh to preserve backward compatibility, since the script runs in a trusted first-party build context. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
451bf56 to
4b0b8f9
Compare
antonis
commented
May 22, 2026
Contributor
Author
antonis
left a comment
There was a problem hiding this comment.
Merging on the CLI bump PR
antonis
added a commit
that referenced
this pull request
May 22, 2026
* chore: update scripts/update-cli.sh to 3.4.3 * fix(ios): Preserve Info.plist preprocessing for auto-release detection (#6211) CLI 3.4.3 disables Xcode Info.plist preprocessing by default. Add --allow-xcode-infoplist-preprocessing to sentry-xcode.sh to preserve backward compatibility, since the script runs in a trusted first-party build context. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
CLI 3.4.3 disables Xcode
Info.plistpreprocessing by default as a security hardening measure. This is a behavior-breaking change that affectssentry-cli react-native xcodeauto-release detection — projects using Xcode variables like$(MARKETING_VERSION)inInfo.plistwould get literal variable names instead of resolved values, silently corrupting release tagging in Sentry.This PR adds
--allow-xcode-infoplist-preprocessingto thesentry-cli react-native xcodeinvocation insentry-xcode.shto preserve backward compatibility. The security concern (untrusted compiler settings passed tocc) does not apply here since this script runs during the user's own Xcode build against their own project.Both the Sentry bot and Cursor Bugbot flagged this as a HIGH severity issue on #6205.
💡 Motivation and Context
Without this fix, every iOS project using
$(MARKETING_VERSION)(the default for modern Xcode projects) would silently upload sourcemaps tagged with the wrong release name after upgrading to this SDK version.💚 How did you test it?
Verified that
--allow-xcode-infoplist-preprocessingis passed to the CLI in the generated command on line 63 ofsentry-xcode.sh.📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
🤖 Generated with Claude Code