Skip to content

fix(ios): Preserve Info.plist preprocessing for auto-release detection#6211

Merged
antonis merged 1 commit into
deps/scripts/update-cli.shfrom
antonis/cli-343-docs
May 22, 2026
Merged

fix(ios): Preserve Info.plist preprocessing for auto-release detection#6211
antonis merged 1 commit into
deps/scripts/update-cli.shfrom
antonis/cli-343-docs

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented May 22, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

CLI 3.4.3 disables Xcode Info.plist preprocessing by default as a security hardening measure. This is a behavior-breaking change that affects sentry-cli react-native xcode auto-release detection — projects using Xcode variables like $(MARKETING_VERSION) in Info.plist would get literal variable names instead of resolved values, silently corrupting release tagging in Sentry.

This PR adds --allow-xcode-infoplist-preprocessing to the sentry-cli react-native xcode invocation in sentry-xcode.sh to preserve backward compatibility. The security concern (untrusted compiler settings passed to cc) does not apply here since this script runs during the user's own Xcode build against their own project.

Both the Sentry bot and Cursor Bugbot flagged this as a HIGH severity issue on #6205.

💡 Motivation and Context

Without this fix, every iOS project using $(MARKETING_VERSION) (the default for modern Xcode projects) would silently upload sourcemaps tagged with the wrong release name after upgrading to this SDK version.

💚 How did you test it?

Verified that --allow-xcode-infoplist-preprocessing is passed to the CLI in the generated command on line 63 of sentry-xcode.sh.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

🤖 Generated with Claude Code

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(ios): Preserve Info.plist preprocessing for auto-release detection by antonis in #6211
  • chore(deps): update CLI to v3.4.3 by github-actions in #6205
  • chore(deps): update Cocoa SDK to v9.14.0 by github-actions in #6204
  • chore(deps): update Maestro to v2.6.0 by github-actions in #6198
  • chore(deps): bump js-cookie from 3.0.5 to 3.0.7 by dependabot in #6203
  • chore(deps): bump @tootallnate/once from 2.0.0 to 2.0.1 by dependabot in #6206
  • chore(deps): update Sentry Android Gradle Plugin to v6.8.1 by github-actions in #6196
  • feat(core): Expose pauseAppHangTracking and resumeAppHangTracking APIs by antonis in #6192

🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label May 22, 2026
CLI 3.4.3 disables Xcode Info.plist preprocessing by default.
Add --allow-xcode-infoplist-preprocessing to sentry-xcode.sh to
preserve backward compatibility, since the script runs in a trusted
first-party build context.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@antonis antonis force-pushed the antonis/cli-343-docs branch from 451bf56 to 4b0b8f9 Compare May 22, 2026 10:56
@antonis antonis changed the title docs(ios): Document CLI 3.4.3 Info.plist preprocessing change fix(ios): Preserve Info.plist preprocessing for auto-release detection May 22, 2026
@antonis antonis marked this pull request as ready for review May 22, 2026 11:01
Copy link
Copy Markdown
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on the CLI bump PR

@antonis antonis merged commit 7cd884a into deps/scripts/update-cli.sh May 22, 2026
88 of 129 checks passed
@antonis antonis deleted the antonis/cli-343-docs branch May 22, 2026 11:14
antonis added a commit that referenced this pull request May 22, 2026
* chore: update scripts/update-cli.sh to 3.4.3

* fix(ios): Preserve Info.plist preprocessing for auto-release detection (#6211)

CLI 3.4.3 disables Xcode Info.plist preprocessing by default.
Add --allow-xcode-infoplist-preprocessing to sentry-xcode.sh to
preserve backward compatibility, since the script runs in a trusted
first-party build context.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant