test(e2e): Assert TTID/TTFD spans share their navigation transaction's trace and parent span - #6530
Merged
Merged
Conversation
…s trace and parent span The e2e suite already asserts navigation transactions carry TTID/TTFD measurements, but did not verify the underlying display spans inherit the transaction's trace_id and reference its root span as parent_span_id. Add that end-to-end guard against orphaned display spans. Closes #6529 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 1 more 🤖 This preview updates automatically when you update the PR. |
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds an end-to-end assertion to the existing
captureSpaceflightNewsScreenTransactione2e test verifying that theui.load.initial_displayandui.load.full_displayspans of a navigation transaction share the transaction'strace_idand reference its root span as theirparent_span_id.The e2e suite already asserts that navigation transactions carry
time_to_initial_display/time_to_full_displaymeasurements, but it did not assert that the underlying display spans are attached to the correct trace and parent span end-to-end.💡 Motivation and Context
A previous defect caused TTID/TTFD spans to be minted with a random
trace_idinstead of inheriting the navigation transaction's, so they rendered as orphaned spans in the trace view. That defect is guarded at the unit layer, but there was no end-to-end check that the spans emitted in a real navigation envelope are correctly parented. This adds that guard against the on-device serialized transaction.Closes #6529.
💚 How did you test it?
captureSpaceflightNewsScreenTransactionMaestro e2e (iOS + Android, auto- and manual-init).oxlint) and type-checks.ready-to-mergelabel.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#6531