ref(replays): Read from the rrweb saved config to see if replay network details is setup - #48967
Merged
Merged
Conversation
…rk details is setup
github-actions
Bot
added
the
Scope: Frontend
ryan953
commented
May 11, 2023
billyvg
reviewed
May 12, 2023
| } | ||
|
|
||
| export type RecordingEvent = eventWithTime; | ||
| export type RecordingOptions = customEvent<{ |
Member
There was a problem hiding this comment.
Hmm we should probably have this type defined in SDK.
billyvg
approved these changes
May 12, 2023
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
…rk details is setup (#48967) Fixes #48733 See also: getsentry/sentry-docs#6943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48733
See also: getsentry/sentry-docs#6943