Skip to content

CHK-13432: fix: force netty-codec-http to 4.2.13.Final (GHSA-m4cv-j2px-7723)#368

Closed
Copilot wants to merge 4 commits into
mainfrom
copilot/chk-13432-fix-netty-http-request-smuggling
Closed

CHK-13432: fix: force netty-codec-http to 4.2.13.Final (GHSA-m4cv-j2px-7723)#368
Copilot wants to merge 4 commits into
mainfrom
copilot/chk-13432-fix-netty-http-request-smuggling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

io.netty:netty-codec-http ≤ 4.2.12.Final is vulnerable to HTTP Request Smuggling via incorrect chunk size parsing. The dependency is transitive via spring-boot-starter-webflux → Spring Boot BOM → Netty, so a direct version pin isn't possible.

Changes

  • build.gradle — adds a resolutionStrategy.eachDependency rule to force netty-codec-http to 4.2.13.Final across all subprojects, following the existing pattern used for Jackson (GHSA-2m67-wjpj-xhg9) and Tomcat (GHSA-rv64-5gf8-9qq8):
if (requested.group == 'io.netty' && requested.name == 'netty-codec-http'
        && requested.version != null && requested.version < '4.2.13.Final') {
    useVersion('4.2.13.Final')
    because('GHSA-m4cv-j2px-7723: HTTP Request Smuggling in Netty < 4.2.13.Final')
}

Resolves Dependabot alert #56 / GHSA-m4cv-j2px-7723 / CHK-13432.

Original prompt

Requested by: catarina.correia@getyourguide.com

Create a branch named CHK-13432-fix-netty-http-request-smuggling

Jira Ticket: CHK-13432
Security Alert: Github_Security_Alert - HTTP Request Smuggling

Context:
This is a security vulnerability fix for HTTP Request Smuggling vulnerability in io.netty:netty-codec-http used by the openapi-validation-java library.

Vulnerability Details:

  • CVE/GHSA: GHSA-m4cv-j2px-7723
  • Severity: MEDIUM
  • Package: io.netty:netty-codec-http
  • Vulnerable Version/Range: >= 4.2.0.Alpha1, <= 4.2.12.Final
  • Patched Version: 4.2.13.Final

Work Needed:

  • Locate netty-codec-http dependency in the dependency tree (it's a transitive dependency from spring-boot-starter-webflux)
  • Add a dependency resolution override in build.gradle to force version 4.2.13.Final
  • Follow the existing pattern already used for Jackson and Tomcat overrides in the resolutionStrategy section
  • Verify patched version 4.2.13.Final appears in dependency tree
  • Run tests following repository's documented test process

⚠️ PR Description Requirements:

  • ALWAYS include the "Implementation Reasoning" section below in the PR description on GitHub

Implementation Reasoning:
Added a resolutionStrategy override in the root build.gradle to force io.netty:netty-codec-http to version 4.2.13.Final. This approach follows the existing pattern used for Jackson and Tomcat security fixes in the same file. The netty-codec-http dependency is transitive (comes from spring-boot-starter-webflux → Spring Boot BOM → Netty), so a direct dependency upgrade isn't possible. This resolution strategy ensures all transitive references to netty-codec-http use the patched version, preventing HTTP Request Smuggling attacks caused by incorrect chunk size parsing.

Security Considerations:

  • Verify io.netty:netty-codec-http 4.2.13.Final appears in the dependency tree after the override
  • Ensure no breaking changes are introduced in the minor version upgrade (4.2.12 → 4.2.13)
  • Test thoroughly to ensure the HTTP Request Smuggling vulnerability is closed
  • Confirm the fix by checking GitHub Dependabot alert Bump mockito from 4.11.0 to 5.7.0 #56 is resolved after merge

Acceptance Criteria:

⚠️ Security Fix: This PR addresses a MEDIUM severity HTTP Request Smuggling vulnerability. Please review carefully.

Ask @catarina-correia for a review.

@gyg-pr-tool gyg-pr-tool Bot changed the title [WIP] Fix HTTP request smuggling vulnerability in netty codec CHK-13432: [WIP] Fix HTTP request smuggling vulnerability in netty codec May 22, 2026
Copilot AI changed the title CHK-13432: [WIP] Fix HTTP request smuggling vulnerability in netty codec fix: force netty-codec-http to 4.2.13.Final (GHSA-m4cv-j2px-7723) May 22, 2026
Copilot AI requested a review from gygrobot May 22, 2026 14:22
@gyg-pr-tool gyg-pr-tool Bot changed the title fix: force netty-codec-http to 4.2.13.Final (GHSA-m4cv-j2px-7723) CHK-13432: fix: force netty-codec-http to 4.2.13.Final (GHSA-m4cv-j2px-7723) May 22, 2026
The gradlew.bat was inadvertently modified to use LF line endings
during the security fix commit. This restores the original CRLF
line endings to match main and avoid unnecessary diff noise.
@catarina-correia catarina-correia deleted the copilot/chk-13432-fix-netty-http-request-smuggling branch May 22, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants